From 0e9536b0a87abc5c5fd217c1dcee5d990988a000 Mon Sep 17 00:00:00 2001 From: Gisle Aune Date: Wed, 3 Oct 2018 20:56:18 +0200 Subject: [PATCH] models2: Fixed StoryCategory UnmarshalGQL validating before writing the value. --- models/story-category.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/models/story-category.go b/models/story-category.go index 6af46ae..00a6d8b 100644 --- a/models/story-category.go +++ b/models/story-category.go @@ -1,6 +1,7 @@ package models import ( + "errors" "fmt" "io" ) @@ -35,15 +36,14 @@ func (e *StoryCategory) IsValid() bool { func (e *StoryCategory) UnmarshalGQL(v interface{}) error { str, ok := v.(string) if !ok { - return fmt.Errorf("enums must be strings") + return errors.New("enums must be strings") } + *e = StoryCategory(str) if !e.IsValid() { - return fmt.Errorf("%s is not a valid StoryCategory", str) + return fmt.Errorf("\"%s\" is not a valid StoryCategory", str) } - *e = StoryCategory(str) - return nil }