GraphQL: Fixed stories resolver crashing if filter is nil.

2018-08-30 20:21:00 +02:00
parent 8bb4dea358
commit 20e53b4f5e
1 changed files with 56 additions and 50 deletions
@@ -28,64 +28,70 @@ type StoriesArg struct {

 // Stories resolves the stories query
 func (r *QueryResolver) Stories(ctx context.Context, args *StoriesArg) ([]*types.StoryResolver, error) {
+	var err error
+
 	filter := args.Filter

 	author := ""
-	if filter != nil && filter.Author != nil {
-		author = *filter.Author
-	}
-
 	category := ""
-	if filter != nil && filter.Category != nil {
-		category = *filter.Category
-	}
-
 	tags := make([]story.Tag, 0, 8)
-	if filter != nil && filter.Tags != nil {
-		for _, tagInput := range *filter.Tags {
-			tags = append(tags, story.Tag{
-				Kind: tagInput.Kind,
-				Name: tagInput.Name,
-			})
-		}
-	}
-
 	earliest := time.Time{}
-	err := error(nil)
-	if filter != nil && filter.EarliestFictionalDate != nil {
-		earliest, err = time.Parse(time.RFC3339Nano, *filter.EarliestFictionalDate)
-		if err != nil {
-			return nil, err
-		}
-	}
-
 	latest := time.Time{}
-	if filter != nil && filter.LatestFictionalDate != nil {
-		latest, err = time.Parse(time.RFC3339Nano, *filter.LatestFictionalDate)
-		if err != nil {
-			return nil, err
-		}
-	}
-
-	unlisted := filter.Unlisted != nil && *filter.Unlisted == true
-	if unlisted {
-		user := session.FromContext(ctx).User()
-		if user == nil {
-			return nil, ErrUnauthorized
-		}
-
-		if author != "" && author != user.ID && !user.Permitted("story.unlisted") {
-			return nil, ErrPermissionDenied
-		}
-
-		author = user.ID
-	}
-
-	open := filter.Open
-
+	unlisted := false
+	open := (*bool)(nil)
 	limit := 0
-	if filter != nil && filter.Limit != nil {
-		limit = int(*filter.Limit)
+
+	if filter != nil {
+		if filter.Author != nil {
+			author = *filter.Author
+		}
+
+		if filter.Category != nil {
+			category = *filter.Category
+		}
+
+		if filter.Tags != nil {
+			for _, tagInput := range *filter.Tags {
+				tags = append(tags, story.Tag{
+					Kind: tagInput.Kind,
+					Name: tagInput.Name,
+				})
+			}
+		}
+
+		if filter.EarliestFictionalDate != nil {
+			earliest, err = time.Parse(time.RFC3339Nano, *filter.EarliestFictionalDate)
+			if err != nil {
+				return nil, err
+			}
+		}
+
+		if filter.LatestFictionalDate != nil {
+			latest, err = time.Parse(time.RFC3339Nano, *filter.LatestFictionalDate)
+			if err != nil {
+				return nil, err
+			}
+		}
+
+		if filter.Limit != nil {
+			limit = int(*filter.Limit)
+		}
+
+		unlisted = filter.Unlisted != nil && *filter.Unlisted == true
+		if unlisted {
+			user := session.FromContext(ctx).User()
+			if user == nil {
+				return nil, ErrUnauthorized
+			}
+
+			if author != "" && author != user.ID && !user.Permitted("story.unlisted") {
+				return nil, ErrPermissionDenied
+			}
+
+			author = user.ID
+		}
+
+		open = filter.Open
 	}

 	stories, err := story.List(author, category, tags, earliest, latest, unlisted, open, limit)