fix tasks endpoint returning wrong values for task.logs.
continuous-integration/drone/push Build is passing
continuous-integration/drone/push Build is passing
This commit is contained in:
@@ -30,8 +30,8 @@ func (r *logRepository) Find(ctx context.Context, id string) (*models.Log, error
|
||||
func (r *logRepository) List(ctx context.Context, filter models.LogFilter) ([]*models.Log, error) {
|
||||
sq := squirrel.Select("log.*").From("log").PlaceholderFormat(squirrel.Dollar)
|
||||
sq = sq.Where(squirrel.Eq{"user_id": filter.UserID})
|
||||
if len(filter.IDs) > 0 {
|
||||
sq = sq.Where(squirrel.Eq{"task_id": filter.IDs})
|
||||
if len(filter.TaskIDs) > 0 {
|
||||
sq = sq.Where(squirrel.Eq{"task_id": filter.TaskIDs})
|
||||
}
|
||||
if len(filter.ItemIDs) > 0 {
|
||||
sq = sq.Where(squirrel.Eq{"item_id": filter.ItemIDs})
|
||||
|
||||
+1
-1
@@ -36,7 +36,7 @@ type LogResult struct {
|
||||
|
||||
type LogFilter struct {
|
||||
UserID string
|
||||
IDs []string
|
||||
TaskIDs []string
|
||||
ItemIDs []string
|
||||
MinTime *time.Time
|
||||
MaxTime *time.Time
|
||||
|
||||
+9
-9
@@ -207,8 +207,8 @@ func (l *Loader) FindProject(ctx context.Context, id string) (*models.ProjectRes
|
||||
}
|
||||
|
||||
logs, err := l.DB.Logs().List(ctx, models.LogFilter{
|
||||
UserID: auth.UserID(ctx),
|
||||
IDs: taskIDs,
|
||||
UserID: auth.UserID(ctx),
|
||||
TaskIDs: taskIDs,
|
||||
})
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -270,8 +270,8 @@ func (l *Loader) ListProjects(ctx context.Context, filter models.ProjectFilter)
|
||||
}
|
||||
|
||||
logs, err := l.DB.Logs().List(ctx, models.LogFilter{
|
||||
UserID: auth.UserID(ctx),
|
||||
IDs: taskIDs,
|
||||
UserID: auth.UserID(ctx),
|
||||
TaskIDs: taskIDs,
|
||||
})
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -331,8 +331,8 @@ func (l *Loader) FindTask(ctx context.Context, id string) (*models.TaskResult, e
|
||||
result.Item, _ = l.DB.Items().Find(ctx, task.ItemID)
|
||||
result.Project, _ = l.DB.Projects().Find(ctx, task.ProjectID)
|
||||
result.Logs, err = l.DB.Logs().List(ctx, models.LogFilter{
|
||||
UserID: task.UserID,
|
||||
IDs: []string{task.ID},
|
||||
UserID: task.UserID,
|
||||
TaskIDs: []string{task.ID},
|
||||
})
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -363,8 +363,8 @@ func (l *Loader) ListTasks(ctx context.Context, filter models.TaskFilter) ([]*mo
|
||||
}
|
||||
|
||||
logs, err := l.DB.Logs().List(ctx, models.LogFilter{
|
||||
UserID: auth.UserID(ctx),
|
||||
IDs: taskIDs,
|
||||
UserID: auth.UserID(ctx),
|
||||
TaskIDs: taskIDs,
|
||||
})
|
||||
if err != nil {
|
||||
return nil, err
|
||||
@@ -394,7 +394,7 @@ func (l *Loader) ListTasks(ctx context.Context, filter models.TaskFilter) ([]*mo
|
||||
}
|
||||
|
||||
for _, log := range logs {
|
||||
if log.TaskID != task.ID {
|
||||
if log.TaskID == task.ID {
|
||||
result.Logs = append(result.Logs, log)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user