feature-scenesystem (#1)

Co-authored-by: Gisle Aune <dev@gisle.me>
Reviewed-on: #1
Co-authored-by: gisle <gisle@hidden-email>
Co-committed-by: gisle <gisle@hidden-email>

app/services/publisher/publisher.go

@@ -110,19 +110,16 @@ func (p *Publisher) Run() {
 	ticker := time.NewTicker(time.Millisecond * 100)
 	deleteList := make([]int, 0, 8)
 	updatedList := make([]models.Device, 0, 16)
-	reassignList := make([]models.Device, 0, 16)
 
 	for range ticker.C {
 		deleteList = deleteList[:0]
 		updatedList = updatedList[:0]
-		reassignList = reassignList[:0]
 
 		p.mu.Lock()
 		for i, scene := range p.scenes {
 			if (!scene.endTime.IsZero() && time.Now().After(scene.endTime)) || scene.Empty() {
 				deleteList = append(deleteList, i-len(deleteList))
 				updatedList = append(updatedList, scene.AllDevices()...)
-				reassignList = append(reassignList, scene.AllDevices()...)
 
 				log.Printf("Removing scene instance for %s (%d)", scene.data.Name, scene.data.ID)
 
@@ -142,14 +139,6 @@ func (p *Publisher) Run() {
 			p.scenes = append(p.scenes[:i], p.scenes[i+1:]...)
 		}
 
-		for _, device := range reassignList {
-			p.reassignDevice(device)
-
-			if p.sceneAssignment[device.ID] != nil {
-				p.sceneAssignment[device.ID].UpsertDevice(device)
-			}
-		}
-
 		for _, device := range updatedList {
 			if !p.started[device.BridgeID] {
 				p.started[device.BridgeID] = true
@@ -170,10 +159,10 @@ func (p *Publisher) Run() {
 // should trigger an update.
 func (p *Publisher) reassignDevice(device models.Device) bool {
 	var selectedAssignment *models.DeviceSceneAssignment
-	for i, assignment := range device.SceneAssignments {
+	for _, assignment := range device.SceneAssignments {
 		duration := time.Duration(assignment.DurationMS) * time.Millisecond
 		if duration <= 0 || time.Now().Before(assignment.StartTime.Add(duration)) {
-			selectedAssignment = &device.SceneAssignments[i]
+			selectedAssignment = &assignment
 		}
 	}
 

models/eventhandler.go

@@ -171,7 +171,7 @@ func (c *EventCondition) checkDevice(key string, device Device) (matches bool, s
 		return c.matches(strconv.FormatFloat(device.State.Temperature, 'f', -1, 64)), false
 	case "scene":
 		if len(device.SceneAssignments) == 0 {
-			return c.matches("-1"), false
+			return false, false
 		}
 
 		sceneId := -1